A common mistake I’ve often fall into is forgetting how to set a default colorscheme for GUI vim editors.
If you’re using gvim, MacVim, to set your default colorscheme, you’ll need to edit (or create if it doesn’t exist) ~/.gvimrc instead of your normal ~/.vimrc.
For example in my ~/.gvimrc:
colorscheme darkblue